fix(Android): Kotlin build issues with RN 0.75.3 by siddarthkay · Pull Request #7913 · wix/react-native-navigation

siddarthkay · 2024-09-17T03:47:58Z

Summary

This PR fixes the following Kotlin build issues which were discovered after I upgraded react-native to 0.75.3 and react-native-navigation to 7.40.1

> Task :react-native-navigation:compileReactNative71DebugKotlin FAILED
e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/
utils/ReactViewGroup.kt:7:59 Unresolved reference: fullBorderRadius

e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/
viewcontrollers/viewcontroller/LayoutDirectionApplier.kt:11:45 Smart cast to 'ReactContext' is impossible, 
because 'instanceManager.currentReactContext' is a property that has open or custom getter

e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/
viewcontrollers/viewcontroller/LayoutDirectionApplier.kt:12:45 Smart cast to 'ReactContext' is impossible, 
because 'instanceManager.currentReactContext' is a property that has open or custom getter

e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/reactNative71/java/com/reactnativenavigation/
react/modal/ModalContentLayout.kt:53:56 Type mismatch: inferred type is MotionEvent? 
but MotionEvent was expected

e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/reactNative71/java/com/reactnativenavigation/
react/modal/ModalContentLayout.kt:53:70 Type mismatch: inferred type is EventDispatcher? 
but EventDispatcher was expected

e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/reactNative71/java/com/reactnativenavigation/
react/modal/ModalContentLayout.kt:56:56 Type mismatch: inferred type is MotionEvent? 
but MotionEvent was expected

e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/reactNative71/java/com/reactnativenavigation/
react/modal/ModalContentLayout.kt:56:70 Type mismatch: inferred type is EventDispatcher? 
but EventDispatcher was expected

e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/reactNative71/java/com/reactnativenavigation/
react/modal/ModalContentLayout.kt:59:54 Type mismatch: inferred type is MotionEvent? 
but MotionEvent was expected

e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/reactNative71/java/com/reactnativenavigation/
react/modal/ModalContentLayout.kt:59:68 Type mismatch: inferred type is EventDispatcher? 
but EventDispatcher was expected

e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/reactNative71/java/com/reactnativenavigation/
react/modal/ModalContentLayout.kt:77:45 Type mismatch: inferred type is MotionEvent? 
but MotionEvent was expected

e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/reactNative71/java/com/reactnativenavigation/
react/modal/ModalContentLayout.kt:77:52 Type mismatch: inferred type is EventDispatcher? 
but EventDispatcher was expected

e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/reactNative71/java/com/reactnativenavigation/
react/modal/ModalContentLayout.kt:82:45 Type mismatch: inferred type is MotionEvent? 
but MotionEvent was expected

e: file:///private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/
react-native-navigation/lib/android/app/src/reactNative71/java/com/reactnativenavigation/
react/modal/ModalContentLayout.kt:82:52 Type mismatch: inferred type is EventDispatcher? 
but EventDispatcher was expected

fixes: #7905, #7911

siddarthkay · 2024-09-17T04:13:44Z

I found 2 new errors :

> Task :react-native-navigation:compileReactNative71DebugJavaWithJavac
/private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/react-native-navigation/lib/
android/app/src/main/java/com/reactnativenavigation/utils/ReactTypefaceUtils.java:99: 
error: cannot find symbol
        || ((oldStyle & Typeface.BOLD) != 0 && weight == ReactTextShadowNode.UNSET)) {
                                                                            ^
  symbol:   variable UNSET
  location: class ReactTextShadowNode
/private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/react-native-navigation/lib/
android/app/src/main/java/com/reactnativenavigation/
utils/ReactTypefaceUtils.java:104: error: cannot find symbol
        || ((oldStyle & Typeface.ITALIC) != 0 && style == ReactTextShadowNode.UNSET)) {
                                                                             ^
  symbol:   variable UNSET
  location: class ReactTextShadowNode

zabojad · 2024-09-23T16:31:09Z

I've just tested it and got:

e: file:///Users/thomasfetiveau/wksp_olap/OlapRN75/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/viewcontroller/LayoutDirectionApplier.kt:16:2 Missing '}

siddarthkay · 2024-09-23T17:04:26Z

@zabojad : probably you missed a } while applying this patch.
I could see builds passing here without any syntax errors -> status-im/status-legacy#21268

zabojad · 2024-09-24T07:58:39Z

hey @siddarthkay ! I've applyied the fix directly from this PR (I did not change any file manually before testing it). Also, when double checking the files of this PR, we see the missing '}' there:

Anyway... It's not a big deal, I just wanted to tell you so that you fix your PR...

Luanluu96 · 2024-10-02T11:05:53Z

in react-native-reanimated resolved like this
as border Radius is not the same with fullBorderWidth

val ReactViewGroup.borderRadius: Float
    get(){
        val uniform: LengthPercentage = (background as? CSSBackgroundDrawable)?.borderRadius?.uniform
            ?: return 0f

        return uniform.resolve(
            width.toFloat(), height.toFloat()
        )
    }

MaxMaesLW · 2024-10-11T13:04:06Z

Any chance this can get verified and merged? I've ran into this issue in a project I'm working on and am kind of blocked until this is resolved.

zzorba · 2024-12-08T23:17:47Z

Second that, any hope this can get merged? Not being able to use the two most recent versions of RN is pretty rough.

DriesVS · 2024-12-28T10:57:26Z

@asafkorem can you check this one please

This commit upgrades `react-native` to `v0.75.3` Following changes were also made : - `NDK` upgraded to `26.1.10909125` - `@react-native/gradle-plugin` is set up using `includeBuild` gradle mechanism which is a better way. - `reactjs` is upgraded to `18.3.1` - `react-native-config` is upgraded to `1.5.3` - `react-native-navigation` is upgraded to `7.40.1` - `react-native-reanimated` is upgraded to `3.16.6` - `react-native-gesture-handler` is upgraded to `2.22.0` - `react-native-keychain` is upgraded to `9.2.2` - patches for react-native-navigation are updated. PR in RNN repo -> wix/react-native-navigation#7913 - patched autolinking behaviour in `react-native` to prevent generating `autolinking.json` in a gradle step. We run gradle in a sandbox with `--offline` so this is not feasible for us. We do the same thing via a nix phase called `autolinkPhase`. - `AGP` is bumped to `8.5.0` and `aapt2` is bumped to `8.5.0-11315950` - we no longer need to patch out `-X` from `script_phases-patched.sh` - `gradle` deps were updated. - `pods` were updated. - `gems` were updated.

updated in react native here -> https://github.com/facebook/react-native/pull/39630/files

siddarthkay · 2025-01-18T02:54:53Z

@zabojad : Thanks! I fixed the missing bracket.

This commit upgrades `react-native` to `v0.75.3` Following changes were also made : - `NDK` upgraded to `26.1.10909125` - `@react-native/gradle-plugin` is set up using `includeBuild` gradle mechanism which is a better way. - `reactjs` is upgraded to `18.3.1` - `react-native-config` is upgraded to `1.5.3` - `react-native-navigation` is upgraded to `7.40.1` - `react-native-reanimated` is upgraded to `3.16.6` - `react-native-gesture-handler` is upgraded to `2.22.0` - `react-native-keychain` is upgraded to `9.2.2` - patches for react-native-navigation are updated. PR in RNN repo -> wix/react-native-navigation#7913 - patched autolinking behaviour in `react-native` to prevent generating `autolinking.json` in a gradle step. We run gradle in a sandbox with `--offline` so this is not feasible for us. We do the same thing via a nix phase called `autolinkPhase`. - `AGP` is bumped to `8.5.0` and `aapt2` is bumped to `8.5.0-11315950` - we no longer need to patch out `-X` from `script_phases-patched.sh` - `gradle` deps were updated. - `pods` were updated. - `gems` were updated.

gosha212 · 2025-01-30T11:44:02Z

@siddarthkay Thanks for the contribution. This fix is implemented during the upgrade to RN 76: #7967

siddarthkay · 2025-01-31T04:08:01Z

Thanks for the update @gosha212

This commit upgrades `react-native` to `v0.75.3` Following changes were also made : - `NDK` upgraded to `26.1.10909125` - `@react-native/gradle-plugin` is set up using `includeBuild` gradle mechanism which is a better way. - `reactjs` is upgraded to `18.3.1` - `react-native-config` is upgraded to `1.5.3` - `react-native-navigation` is upgraded to `7.40.1` - `react-native-reanimated` is upgraded to `3.16.6` - `react-native-gesture-handler` is upgraded to `2.22.0` - `react-native-keychain` is upgraded to `9.2.2` - patches for react-native-navigation are updated. PR in RNN repo -> wix/react-native-navigation#7913 - patched autolinking behaviour in `react-native` to prevent generating `autolinking.json` in a gradle step. We run gradle in a sandbox with `--offline` so this is not feasible for us. We do the same thing via a nix phase called `autolinkPhase`. - `AGP` is bumped to `8.5.0` and `aapt2` is bumped to `8.5.0-11315950` - we no longer need to patch out `-X` from `script_phases-patched.sh` - `gradle` deps were updated. - `pods` were updated. - `gems` were updated.

siddarthkay force-pushed the fix-android-build-issues-with-react-native-75 branch from 134ba34 to 21811c0 Compare September 17, 2024 03:49

siddarthkay force-pushed the fix-android-build-issues-with-react-native-75 branch from d510996 to f1bae0f Compare September 17, 2024 04:52

siddarthkay mentioned this pull request Sep 18, 2024

upgrade react-native to 0.75.3 status-im/status-legacy#21268

Closed

13 tasks

siddarthkay force-pushed the fix-android-build-issues-with-react-native-75 branch from f1bae0f to 4af10d4 Compare January 17, 2025 09:33

siddarthkay added 2 commits January 18, 2025 08:24

fix(Android): Kotlin build issues with RN 0.75.3

67630bf

fix(Android): get constants from ReactConstants

621cfa7

updated in react native here -> https://github.com/facebook/react-native/pull/39630/files

siddarthkay force-pushed the fix-android-build-issues-with-react-native-75 branch from 4af10d4 to 621cfa7 Compare January 18, 2025 02:54

gosha212 closed this Jan 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Android): Kotlin build issues with RN 0.75.3#7913

fix(Android): Kotlin build issues with RN 0.75.3#7913
siddarthkay wants to merge 2 commits into
wix:masterfrom
siddarthkay:fix-android-build-issues-with-react-native-75

siddarthkay commented Sep 17, 2024

Uh oh!

siddarthkay commented Sep 17, 2024

Uh oh!

zabojad commented Sep 23, 2024

Uh oh!

siddarthkay commented Sep 23, 2024

Uh oh!

zabojad commented Sep 24, 2024

Uh oh!

Luanluu96 commented Oct 2, 2024 •

edited

Loading

Uh oh!

MaxMaesLW commented Oct 11, 2024

Uh oh!

zzorba commented Dec 8, 2024

Uh oh!

DriesVS commented Dec 28, 2024

Uh oh!

siddarthkay commented Jan 18, 2025

Uh oh!

gosha212 commented Jan 30, 2025

Uh oh!

siddarthkay commented Jan 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

siddarthkay commented Sep 17, 2024

Summary

Uh oh!

siddarthkay commented Sep 17, 2024

Uh oh!

zabojad commented Sep 23, 2024

Uh oh!

siddarthkay commented Sep 23, 2024

Uh oh!

zabojad commented Sep 24, 2024

Uh oh!

Luanluu96 commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MaxMaesLW commented Oct 11, 2024

Uh oh!

zzorba commented Dec 8, 2024

Uh oh!

DriesVS commented Dec 28, 2024

Uh oh!

siddarthkay commented Jan 18, 2025

Uh oh!

gosha212 commented Jan 30, 2025

Uh oh!

siddarthkay commented Jan 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Luanluu96 commented Oct 2, 2024 •

edited

Loading